Skip to content

Add support for Redis 7 functions #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 22, 2022
Merged

Add support for Redis 7 functions #1998

merged 10 commits into from
Feb 22, 2022
+249 −16

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 17, 2022 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Is the changes added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

close #1933, close #1952, close #1953, close #1954, close #1955, close #1956, close #1957, close #1958, close #1959, close #1960, close #1961

Sorry, something went wrong.

@dvora-h dvora-h requested a review from chayim February 17, 2022 08:49
@dvora-h dvora-h added feature New feature redis-7 labels Feb 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #1998 (4d4ff34) into master (d56baeb) will increase coverage by 0.03%.
The diff coverage is 97.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
+ Coverage   92.67%   92.71%   +0.03%     
==========================================
  Files          99      100       +1     
  Lines       20717    20825     +108     
==========================================
+ Hits        19200    19307     +107     
- Misses       1517     1518       +1
Impacted Files Coverage Δ
redis/client.py 89.39% <ø> (ø)
redis/commands/core.py 88.30% <91.42%> (+0.06%) ⬆️
redis/connection.py 86.52% <100.00%> (+0.06%) ⬆️
tests/conftest.py 87.60% <100.00%> (ø)
tests/test_commands.py 99.26% <100.00%> (ø)
tests/test_function.py 100.00% <100.00%> (ø)
tests/test_scripting.py 100.00% <100.00%> (ø)
redis/asyncio/client.py 90.45% <0.00%> (-0.18%) ⬇️
redis/asyncio/connection.py 82.65% <0.00%> (-0.12%) ⬇️
tests/test_cluster.py 98.42% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56baeb...4d4ff34. Read the comment docs.

chayim
chayim reviewed Feb 17, 2022
View reviewed changes
chayim
chayim reviewed Feb 17, 2022
View reviewed changes
chayim
chayim reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please take a look at getting this connected to the decoders?

@dvora-h dvora-h closed this Feb 21, 2022
@dvora-h dvora-h reopened this Feb 21, 2022
chayim
chayim approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PERFECT!

@dvora-h
Merge branch 'master' into add-functions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d7309b8
@dvora-h
linters

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4d4ff34
@dvora-h dvora-h merged commit fa76ac4 into redis:master Feb 22, 2022
@dvora-h dvora-h deleted the add-functions branch February 22, 2022 11:12
@dvora-h dvora-h mentioned this pull request May 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chayim chayim

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
feature New feature redis-7
Projects
None yet
Milestone
No milestone
3 participants
@dvora-h @codecov-commenter @chayim